Added support for empty size modifier in DfuSeFormat#21
Conversation
There was a problem hiding this comment.
Pull request overview
Updates DFUSe alternate-setting string parsing to handle STM32 devices that omit the size modifier (K/M/space) in memory layout descriptors, addressing issue #20.
Changes:
- Relaxed the DFUSe memory layout regex to allow an empty size modifier.
- Updated parsing logic to safely handle a missing size modifier without indexing into an empty string.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
Thanks for the PR! Two small things to fix in the commit message:
|
Signed-off-by: stanislav.rozum <stanislav.rozum@seznam.cz>
|
I am a bit lost in these waters, learned about amend, and Signed-off-by. I probably made a mistake, as I see a new commit instead of the previous one being edited, and I am going to attempt to fix that. |
Standa-R
force-pushed
the
SupportEmptySizeModifierInDfuSeFormat
branch
from
b12158f to
ae37c4c
Compare
|
Ah, ok, easier than I thought. Thanks for the advice and the opportunity to learn new things. |
|
Thanks for your contribution! I will publish a new release with your fix in the coming weeks. |
Some STM32 MCUs, e.g., the STM32L07x family, omit the size modifier in their alternate strings. This improves the Regex to account for that and adjusts the following logic, see fix #20 for more details.